Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pretty_urls): bring up #152

Merged
merged 6 commits into from Dec 7, 2019
Merged

feat(pretty_urls): bring up #152

merged 6 commits into from Dec 7, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Dec 5, 2019

Bring up a prettyUrls() to rewrite urls to pretty URLs. Used to remove duplicated code introduced in hexojs/hexo#3691 & hexojs/hexo#3893.

Since pretty_urls is already applied for url_for and full_url_for in #143, this PR utilize prettyUrls() for url_for and full_url_for as well.

Also, hexojs/hexo#3893 should be closed & hexojs/hexo#3691 should be revert as full_url_for already has built-in pretty_urls support. I might open another PR to update the related code & test after newer version of hexo-util is released.

@SukkaW SukkaW requested review from segayuu and curbengh Dec 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage increased (+0.06%) to 96.798% when pulling 62d1dc3 on SukkaW:feat_pretty_urls into e4eb60a on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage increased (+0.05%) to 96.792% when pulling 3045fcf on SukkaW:feat_pretty_urls into e4eb60a on hexojs:master.

@SukkaW SukkaW requested a review from YoshinoriN Dec 5, 2019
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@curbengh curbengh mentioned this pull request Dec 7, 2019
1 of 2 tasks complete
@SukkaW SukkaW merged commit e736e1b into hexojs:master Dec 7, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.05%) to 96.792%
Details
@curbengh curbengh mentioned this pull request Dec 9, 2019
1 of 2 tasks complete
@SukkaW SukkaW mentioned this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.