Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(highlight): adjust the layout of the highlight code block #153

merged 1 commit into from Dec 10, 2019


Copy link

SukkaW commented Dec 9, 2019

In this PR I just simply revert #132 because #132 introduces just too much Breaking Changes, see discussion at #132 and related issue #145.

IMHO, we should not bring any style changes in highlightjs any more. It will break too much things, especially when we are going to deprecate highlightjs and bring up prismjs.

Hexo has nearly 300 themes, "NexT theme works fine" is just not an enough excuse.

cc @jiangtj @stevenjoezhang @ppoffice

@SukkaW SukkaW requested a review from curbengh Dec 9, 2019

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2019

Coverage Status

Coverage increased (+0.02%) to 96.811% when pulling 2741cc3 on SukkaW:master into e736e1b on hexojs:master.


This comment has been minimized.

Copy link
Member Author

SukkaW commented Dec 9, 2019

Also, we need to merge this PR and release a new version ASAP. Hexo needs a emergency release to include this PR and #147

@SukkaW SukkaW requested a review from YoshinoriN Dec 9, 2019
@curbengh curbengh merged commit 6327c2d into hexojs:master Dec 10, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
continuous-integration/appveyor/pr AppVeyor build succeeded
coverage/coveralls Coverage increased (+0.02%) to 96.811%
@SukkaW SukkaW mentioned this pull request Dec 12, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.