Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmlTag - toString() before match() for scalar values. #176

Merged
merged 3 commits into from Jan 26, 2020

Conversation

@KentarouTakeda
Copy link
Contributor

KentarouTakeda commented Jan 18, 2020

Fixed crash when entering a numerical value into fb_app_id of open_graph helper.

Facebook app_id is a numeric string, but if it is set in _config.yml without quotes, the yml parser will recognize it as number.

1.8.0 and later versions crashed if the value was set to number.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 18, 2020

Coverage Status

Coverage remained the same at 96.994% when pulling 5eb5c7a on KentarouTakeda:numeric-meta-value into ddcdc31 on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 18, 2020

Coverage Status

Coverage remained the same at 96.994% when pulling 96f9369 on KentarouTakeda:numeric-meta-value into ddcdc31 on hexojs:master.

lib/html_tag.js Outdated Show resolved Hide resolved
KentarouTakeda and others added 2 commits Jan 18, 2020
Co-Authored-By: Sukka <isukkaw@gmail.com>
@SukkaW
SukkaW approved these changes Jan 18, 2020
Copy link
Member

SukkaW left a comment

LGTM!

@SukkaW SukkaW merged commit 4e7c24e into hexojs:master Jan 26, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 96.994%
Details
@SukkaW SukkaW mentioned this pull request Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.