Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add encodeURL() #77

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@curbengh
Copy link
Contributor

commented Sep 2, 2019

This PR is stemmed from IDN parsing issue (hexojs/hexo-generator-feed#63). It was later (partially) fixed in hexojs/hexo-generator-feed#82, without encodeURI the root value. Full fix is later proposed in hexojs/hexo-generator-feed#88.

IDN incompatibility is also found in hexo-generator-sitemap and open_graph().

All the proposed fixes actually share similar function, so I propose to put it in hexo-util instead.

curbengh added 2 commits Aug 30, 2019
@coveralls

This comment has been minimized.

Copy link

commented Sep 2, 2019

Coverage Status

Coverage increased (+0.05%) to 95.949% when pulling 2f39ee3 on curbengh:encode-url into 2ac2ba8 on hexojs:master.

lib/encode_url.js Show resolved Hide resolved
@SukkaW
SukkaW approved these changes Sep 2, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@tomap what do you think, in relation to the IDN issue?

@tomap

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Looks good. unit tests seem to cover all cases

@tomap tomap merged commit 2358028 into hexojs:master Sep 3, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.05%) to 95.949%
Details

@curbengh curbengh deleted the curbengh:encode-url branch Sep 3, 2019

This was referenced Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.