Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(full_url_for): bring up a new helper #84

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@SukkaW
Copy link
Member

commented Sep 11, 2019

@coveralls

This comment has been minimized.

Copy link

commented Sep 11, 2019

Coverage Status

Coverage increased (+0.09%) to 96.088% when pulling e7f4275 on SukkaW:full_url_for into 8daee5b on hexojs:master.

@SukkaW

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

The test will passed after #83 is fixed.

@curbengh

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

The test pass now, just need to remove console.log and fix line ending.

@SukkaW SukkaW force-pushed the SukkaW:full_url_for branch from 61f0501 to 6b7918a Sep 14, 2019
Copy link
Contributor

left a comment

just noticed some minor stuff

lib/full_url_for.js Outdated Show resolved Hide resolved
test/full_url_for.spec.js Outdated Show resolved Hide resolved
test/full_url_for.spec.js Show resolved Hide resolved
Apply suggestions from code review by @curbengh

- Remove useless code comment
- Remove never used test configuration
@SukkaW SukkaW force-pushed the SukkaW:full_url_for branch from dffe465 to e7f4275 Sep 14, 2019
@curbengh curbengh merged commit 2de7c15 into hexojs:master Sep 14, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.09%) to 96.088%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.