New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple config issue #2518 #2520

Merged
merged 4 commits into from Apr 20, 2017

Conversation

3 participants
@NoahDragon
Member

NoahDragon commented Apr 18, 2017

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@NoahDragon NoahDragon changed the title from Update index.js to Fix multiple config issue #2518 Apr 18, 2017

@coveralls

This comment has been minimized.

coveralls commented Apr 18, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling eff35b6 on Fix-multi-config-issue-#2518 into 5134cba on master.

@coveralls

This comment has been minimized.

coveralls commented Apr 18, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 6e30d01 on Fix-multi-config-issue-#2518 into 5134cba on master.

@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 931afed on Fix-multi-config-issue-#2518 into 5134cba on master.

@NoahDragon

This comment has been minimized.

Member

NoahDragon commented Apr 19, 2017

Added test cases from #2521

@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 3552c92 on Fix-multi-config-issue-#2518 into 5134cba on master.

@teggr

teggr approved these changes Apr 20, 2017

I've tested locally and these changes fix #2518

@NoahDragon NoahDragon merged commit fbdee90 into master Apr 20, 2017

3 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 97.183%
Details

@NoahDragon NoahDragon deleted the Fix-multi-config-issue-#2518 branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment