Skip to content

/ hexo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple config issue #2518 #2520

Merged
merged 4 commits into from Apr 20, 2017
Merged

Fix multiple config issue #2518 #2520

merged 4 commits into from Apr 20, 2017

Conversation

@NoahDragon
Copy link
Member

@NoahDragon NoahDragon commented Apr 18, 2017 •
edited

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.
@NoahDragon
Update index.js
Loading status checks…
eff35b6
@NoahDragon NoahDragon changed the title Update index.js Fix multiple config issue #2518 Apr 18, 2017
@coveralls
Copy link

@coveralls coveralls commented Apr 18, 2017 •
edited

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling eff35b6 on Fix-multi-config-issue-#2518 into 5134cba on master.
@NoahDragon
Update index.js
Loading status checks…
6e30d01
@coveralls
Copy link

@coveralls coveralls commented Apr 18, 2017 •
edited

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 6e30d01 on Fix-multi-config-issue-#2518 into 5134cba on master.
This was referenced Apr 18, 2017
Closed
Closed
@NoahDragon
Create _config.json
Loading status checks…
931afed
@coveralls
Copy link

@coveralls coveralls commented Apr 19, 2017 •
edited

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 931afed on Fix-multi-config-issue-#2518 into 5134cba on master.
@NoahDragon
Update hexo.js
Loading status checks…
3552c92
@NoahDragon
Copy link
Member Author

@NoahDragon NoahDragon commented Apr 19, 2017

Added test cases from #2521
@coveralls
Copy link

@coveralls coveralls commented Apr 19, 2017 •
edited

Coverage Status

Coverage increased (+0.0007%) to 97.183% when pulling 3552c92 on Fix-multi-config-issue-#2518 into 5134cba on master.
This was referenced Apr 19, 2017
Closed
Closed
@teggr
teggr approved these changes Apr 20, 2017
View changes
Copy link

@teggr teggr left a comment

I've tested locally and these changes fix #2518
@NoahDragon NoahDragon merged commit fbdee90 into master Apr 20, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 97.183%
Details
This was referenced Apr 21, 2017
Closed
Closed
@NoahDragon NoahDragon deleted the Fix-multi-config-issue-#2518 branch May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teggr teggr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@NoahDragon @coveralls @teggr