New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added command line option `output` to write db.json and _multiconfig.… #3122

Merged
merged 2 commits into from Apr 25, 2018

Conversation

3 participants
@mgoldsborough
Contributor

mgoldsborough commented Apr 16, 2018

I'm working with a read-only file system and I need a way to direct the output to a different path.

I added command line option output to write db.json and _multiconfig.yml to a path provided

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

coveralls commented Apr 16, 2018

Coverage Status

Coverage increased (+0.003%) to 97.217% when pulling 83b1912 on mgoldsborough:outputPath into 373b9c7 on hexojs:master.

@@ -14,6 +15,22 @@ describe('config flag handling', () => {
function ConsoleReader() {
this.reader = [];
this.d = function(...args) {
var type = 'debug';

This comment has been minimized.

@JLHwung

JLHwung Apr 17, 2018

Collaborator

If the differences of this.d and this.i are only type, could you refactor into a factory so that

this.d = readerStub("debug")
this.i = readerStub("info")

Thanks.

This comment has been minimized.

@mgoldsborough

mgoldsborough Apr 18, 2018

Contributor

I was just copying the style of the existing code. I didn't want to touch to many lines. It's also a test case, not production code. If you want this refactored, change impact this.w and this.e which are below these changes in the same file.

If you'd like this refactored, let me know. Otherwise I'll leave it as it.

This comment has been minimized.

@mgoldsborough

@JLHwung JLHwung merged commit ad33b3c into hexojs:master Apr 25, 2018

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 97.217%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment