New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node.js v9 and support v10 on AppVeyor #3276

Merged
merged 1 commit into from Oct 2, 2018

Conversation

4 participants
@YoshinoriN
Member

YoshinoriN commented Oct 1, 2018

Node.js v9 is already EOL.
Drop v9 and support v10 on AppVeyor.

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

coveralls commented Oct 1, 2018

Coverage Status

Coverage remained the same at 97.273% when pulling 07b23aa on YoshinoriN:appveyor-node10 into 0b26940 on hexojs:master.

@tomap

tomap approved these changes Oct 2, 2018

LGTM
only 8 & 10 are LTS

@segayuu

segayuu approved these changes Oct 2, 2018

LGTM!

@segayuu segayuu merged commit 97e8f3c into hexojs:master Oct 2, 2018

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.273%
Details

@YoshinoriN YoshinoriN deleted the YoshinoriN:appveyor-node10 branch Oct 2, 2018

@YoshinoriN

This comment has been minimized.

Member

YoshinoriN commented Oct 2, 2018

@tomap @segayuu
Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment