Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update dependencies minor or patch version #3300

Merged
merged 2 commits into from Oct 23, 2018

Conversation

3 participants
@YoshinoriN
Copy link
Member

commented Oct 22, 2018

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

commented Oct 22, 2018

Coverage Status

Coverage remained the same at 97.27% when pulling cfa50d8 on YoshinoriN:update-dependencies into ce531c0 on hexojs:master.

@segayuu
Copy link
Contributor

left a comment

LGTM! (as conflict was done after merging another PR, resolve and merge)

@segayuu segayuu merged commit 8d33f3c into hexojs:master Oct 23, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 97.27%
Details

@YoshinoriN YoshinoriN deleted the YoshinoriN:update-dependencies branch Oct 23, 2018

@YoshinoriN

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

@segayuu
Thank you for resolve conflict. From next time I will rebase and re-push by myself, if conflict occurs 😄
Sorry, basically weekday daytime I can't change OSS source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.