Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful destructuring assignment #3324

Merged
merged 8 commits into from Nov 5, 2018

Conversation

3 participants
@segayuu
Copy link
Contributor

commented Nov 2, 2018

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested a review from hexojs/core Nov 2, 2018

@coveralls

This comment has been minimized.

Copy link

commented Nov 2, 2018

Coverage Status

Coverage decreased (-0.04%) to 97.227% when pulling 54ba494 on segayuu:useful-destructuring-assignment into 51808d5 on hexojs:master.

@NoahDragon
Copy link
Member

left a comment

LGTM.

@segayuu segayuu merged commit b6394c7 into hexojs:master Nov 5, 2018

2 of 4 checks passed

codeclimate 9 issues to fix
Details
coverage/coveralls Coverage decreased (-0.04%) to 97.227%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@segayuu segayuu deleted the segayuu:useful-destructuring-assignment branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.