Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor self #3329

Merged
merged 3 commits into from Nov 7, 2018

Conversation

3 participants
@segayuu
Copy link
Contributor

commented Nov 5, 2018

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested a review from hexojs/core Nov 5, 2018

@coveralls

This comment has been minimized.

Copy link

commented Nov 5, 2018

Coverage Status

Coverage increased (+6.0e-05%) to 97.228% when pulling dd1f7ad on segayuu:Refactor-self into 087b3fa on hexojs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Nov 5, 2018

Coverage Status

Coverage increased (+6.0e-05%) to 97.228% when pulling dd1f7ad on segayuu:Refactor-self into 087b3fa on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

commented Nov 5, 2018

Coverage Status

Coverage decreased (-0.0007%) to 97.227% when pulling 67316d0 on segayuu:Refactor-self into 087b3fa on hexojs:master.

@segayuu segayuu force-pushed the segayuu:Refactor-self branch from 24bb1b0 to edc961a Nov 5, 2018

@segayuu segayuu force-pushed the segayuu:Refactor-self branch from 793e6dc to 67316d0 Nov 5, 2018

@tomap

tomap approved these changes Nov 6, 2018

@segayuu segayuu merged commit 2ed17cd into hexojs:master Nov 7, 2018

2 of 4 checks passed

codeclimate 1 issue to fix
Details
coverage/coveralls Coverage decreased (-0.0007%) to 97.227%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@segayuu segayuu deleted the segayuu:Refactor-self branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.