Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Global asset folder not working when source dir is changed another path #3399

Merged
merged 3 commits into from Mar 24, 2019

Conversation

4 participants
@xiaomingplus
Copy link
Contributor

commented Dec 24, 2018

fix #3398

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

commented Dec 24, 2018

Coverage Status

Coverage remained the same at 97.265% when pulling 2a96c85 on xiaomingplus:master into 6b9acc0 on hexojs:master.

@xiaomingplus

This comment has been minimized.

Copy link
Contributor Author

commented Dec 26, 2018

Any one can review this?

@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

Sorry, We have many repositories and need to maintain them.
Would you please wait patiently ? Thanks ☺️

@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@xiaomingplus
It's so sorry, very late reply...
I think this issue caused by #3410

I would be grateful if you re-create PR about fix #3410.
Thanks :)

@xiaomingplus

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

@YoshinoriN it's can be reviewed now.I add a unit test for this change.

@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@xiaomingplus
Thanks :)
I will check it PR this weekend.

@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

@xiaomingplus
I tested this locally & works well. LGTM :)

Just to be sure, is this problem is global asset floder's problem. correct?

If yes, would you please change your issue & PR title? I think it is better "global asset folder" words include in the title.

@xiaomingplus xiaomingplus changed the title fix: Change source config,the source assets folder can't be generated fix: Global asset folder not working when source dir is changed another path Mar 24, 2019

@xiaomingplus

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2019

@YoshinoriN yep, I have changed the title.

@YoshinoriN YoshinoriN merged commit 979c988 into hexojs:master Mar 24, 2019

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.265%
Details

@YoshinoriN YoshinoriN added the bug label Mar 24, 2019

@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Merged!!
Thank you for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.