Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .npmignore #3569

Merged
merged 1 commit into from Jun 2, 2019
Merged

chore: remove .npmignore #3569

merged 1 commit into from Jun 2, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jun 2, 2019

What does it do?

Current package.json' already specify the files that would be included in npm publish`, so .npmignore is no longer needed.

Taken from hexojs/hexo-renderer-marked#96.

How to test

git clone -b npmignore https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.265% when pulling 040f201 on weyusi:npmignore into a83280f on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.265% when pulling 040f201 on weyusi:npmignore into a83280f on hexojs:master.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 18aa36c into hexojs:master Jun 2, 2019
@curbengh curbengh deleted the npmignore branch June 5, 2019 06:08
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants