Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .npmignore #3569

Merged
merged 1 commit into from Jun 2, 2019

Conversation

3 participants
@curbengh
Copy link
Contributor

commented Jun 2, 2019

What does it do?

Current package.json' already specify the files that would be included in npm publish`, so .npmignore is no longer needed.

Taken from hexojs/hexo-renderer-marked#96.

How to test

git clone -b npmignore https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Passed the CI test.
weyusi
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2019

Coverage Status

Coverage remained the same at 97.265% when pulling 040f201 on weyusi:npmignore into a83280f on hexojs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Jun 2, 2019

Coverage Status

Coverage remained the same at 97.265% when pulling 040f201 on weyusi:npmignore into a83280f on hexojs:master.

@YoshinoriN
Copy link
Member

left a comment

LGTM :)

@YoshinoriN YoshinoriN merged commit 18aa36c into hexojs:master Jun 2, 2019

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.265%
Details

@curbengh curbengh deleted the curbengh:npmignore branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.