Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node 6 #3598

Merged
merged 3 commits into from Jul 1, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Jun 27, 2019

What does it do?

Drop Node 6 as per #3508 . It has reached EOL since 2019-04-30.

How to test

git clone -b drop-node6 https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.
weyusi
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jun 27, 2019

Some considerations:

  • will there be v3.10.0?
    • it's still possible by creating a separate branch.
  • might need the following in .eslintrc if someone wants to use ES2017/2018.
  "parserOptions": {
    "ecmaVersion": 2018
  }
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 97.148% when pulling 75d23e2 on weyusi:drop-node6 into 7fba3c1 on hexojs:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 97.148% when pulling 5a61477 on weyusi:drop-node6 into 7fba3c1 on hexojs:master.

@YoshinoriN YoshinoriN mentioned this pull request Jun 28, 2019
17 of 53 tasks complete
@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jun 28, 2019

will there be v3.10.0?

I think maybe no.

it's still possible by creating a separate branch.

I prefer to create a branch by new version. But, hexo team seems has never created new branch. (Sorry I'm not familiar with hexo team development flow)

IMO, we can merge this PR to master. Because, maybe we will not release a patch version.

@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jun 28, 2019

might need the following in .eslintrc in someone wants to use ES2017/2018.

I think maybe it's better to upgrade eslint-config-hexo.

@segayuu
How do you think?

@YoshinoriN YoshinoriN mentioned this pull request Jun 28, 2019
@curbengh curbengh added this to the v4.0.0 milestone Jun 28, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jun 28, 2019

can someone restart the appveyor build with cleared cache?

@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Jun 28, 2019

How about re-commit & force-push?
Or, disable cache settings once by appveyor.yml

@segayuu

This comment has been minimized.

Copy link
Contributor

segayuu commented Jun 28, 2019

@YoshinoriN eslint-config-hexo should be updated. It relies on eslint-config-node to properly manage the native API of node.js. Now that the LTS version of node.js has changed, it should be updated.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jun 29, 2019

I created a new PR for eslint-config-hexo (hexojs/eslint-config-hexo#16).

weyusi added 2 commits Jun 29, 2019
weyusi
This reverts commit d92195c.
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Jun 29, 2019

How about re-commit & force-push?
Or, disable cache settings once by appveyor.yml

disable then re-enable cache works. Remember to squash them though.

Copy link
Member

YoshinoriN left a comment

LGTM 👍

@YoshinoriN YoshinoriN merged commit d7a7f97 into hexojs:master Jul 1, 2019
4 checks passed
4 checks passed
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.148%
Details
@curbengh curbengh deleted the curbengh:drop-node6 branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.