Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 #3606

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Jul 1, 2019

What does it do?

Update eslint to v6.
eslint@6 enable no-prototype-builtins rule by default, which entails the refactors.

How to test

git clone -b eslint-prototype https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.
    Closes #3596
@curbengh curbengh added this to the v4.0.0 milestone Jul 1, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 1, 2019

Coverage Status

Coverage remained the same at 97.148% when pulling cebcbf4 on weyusi:eslint-prototype into fe107a1 on hexojs:master.

@curbengh curbengh changed the title Eslint prototype chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 Jul 1, 2019
Copy link
Member

YoshinoriN left a comment

LGTM :)

@YoshinoriN YoshinoriN merged commit c2e4672 into hexojs:master Jul 6, 2019
3 of 4 checks passed
3 of 4 checks passed
codeclimate 4 issues to fix
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.148%
Details
@curbengh curbengh deleted the curbengh:eslint-prototype branch Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.