Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 #3606

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@curbengh
Copy link
Contributor

@curbengh curbengh commented Jul 1, 2019

What does it do?

Update eslint to v6.
eslint@6 enable no-prototype-builtins rule by default, which entails the refactors.

How to test

git clone -b eslint-prototype https://github.com/weyusi/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.
    Closes #3596
@curbengh curbengh added this to the v4.0.0 milestone Jul 1, 2019
@coveralls
Copy link

@coveralls coveralls commented Jul 1, 2019

Coverage Status

Coverage remained the same at 97.148% when pulling cebcbf4 on weyusi:eslint-prototype into fe107a1 on hexojs:master.

@curbengh curbengh changed the title Eslint prototype chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1 Jul 1, 2019
Copy link
Member

@yoshinorin yoshinorin left a comment

LGTM :)

@yoshinorin yoshinorin merged commit c2e4672 into hexojs:master Jul 6, 2019
3 of 4 checks passed
@curbengh curbengh deleted the eslint-prototype branch Jul 6, 2019
oncletom added a commit to oncletom/hexo that referenced this issue Jan 17, 2020
…ojs#3606)

* chore(deps-dev): update eslint requirement from ^5.9.0 to ^6.0.1

* refactor: call hasOwnProperty from Object.prototype

https://eslint.org/docs/6.0.0/rules/no-prototype-builtins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants