Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open_graph): remove index.html from url #3661

Merged
merged 7 commits into from Sep 27, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Aug 10, 2019

What does it do?

Uses canonical url (the one that doesn't end with index.html) for open graph tags.

How to test

git clone -b ograph-canonical https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 10, 2019

Coverage Status

Coverage increased (+0.002%) to 97.25% when pulling 7f61736 on curbengh:ograph-canonical into ffe4eaa on hexojs:master.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Aug 18, 2019

Related to #1306

@SukkaW SukkaW requested a review from segayuu Aug 27, 2019
Copy link
Contributor

segayuu left a comment

LGTM!

@curbengh curbengh changed the title fix(open_graph): remove index.html from url WIP fix(open_graph): remove index.html from url Aug 28, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Aug 28, 2019

Please don't merge this yet, I would like to introduce canonical_url option which also remove "index.html" from post.permalink. Once that option is available, we can use the option to decide whether to process this.url.

Edit: Pending #3691

Edit: Uses config.pretty_urls.trailing_index.

@curbengh curbengh force-pushed the curbengh:ograph-canonical branch from e6c9788 to ce870e2 Sep 23, 2019
@curbengh curbengh changed the title WIP fix(open_graph): remove index.html from url fix(open_graph): remove index.html from url Sep 23, 2019
@curbengh curbengh added this to To do in v4.0.0 Sep 27, 2019
@curbengh curbengh added this to the v4.0.0 milestone Sep 27, 2019
@curbengh curbengh force-pushed the curbengh:ograph-canonical branch from 5fe8bda to 7f61736 Sep 27, 2019
@curbengh curbengh requested a review from hexojs/core Sep 27, 2019
@SukkaW
SukkaW approved these changes Sep 27, 2019
v4.0.0 automation moved this from To do to In progress Sep 27, 2019
@curbengh curbengh merged commit af99506 into hexojs:master Sep 27, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.002%) to 97.25%
Details
v4.0.0 automation moved this from In progress to Done Sep 27, 2019
@curbengh curbengh deleted the curbengh:ograph-canonical branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.0.0
  
Done
4 participants
You can’t perform that action at this time.