New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(meta_generator): drop cheerio #3671
Conversation
regardless the value of 'content'
Previous commit only works on post, not page This reverts commit 325f303.
Maybe it's not necessary to use the xhml syntax?
|
btw, if anyone's worry about html in a code block, the brackets are encoded, <figure class="highlight html"><table><tbody><tr><td class="code"><pre><span class="line"><span class="tag"><<span class="name">head</span>></span><span class="tag"></<span class="name">head</span>></span></span><br></pre></td></tr></tbody></table></figure> |
I forgot to add a unit test where Edit: added decreased coverage may be due to shorter lines/functions. |
squashed some commits. |
* refactor(meta_generator): drop cheerio * fix(meta_generator): append to </title> * test(meta_generator): remove irrelevant head tag test * test(render): disable meta_generator * fix(meta_generator): do not append if there is existing tag, regardless the value of 'content' * test(open_generator): test existing generator tag * test(meta_generator): tag should be added only once Previous commit only works on post, not page This reverts commit 325f303.
What does it do?
Less breaking alternative to #3669
x-post from that PR:
How to test
Pull request tasks