Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf(external_link): drop cheerio and use regex #3685
What does it do?
Drop cheerio in
How to test
git clone -b drop-cheerio-for-external-link https://github.com/sukkaw/hexo.git cd hexo npm install npm test
The performance increased by nearly
Pull request tasks
This PR drops cheerio (along with its deps) and replace it with even less LOC than before. The way I see it, this is equivalent to >99% reduction of LOC. In this case, I'm certain regex+replace can perform at least as fast as cheerio.
LOC reduction + no loss in performance =