Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop lodash for lib/plugins/console/deploy #3785

Merged
merged 1 commit into from Oct 27, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 21, 2019

What does it do?

This PR is a part of #3753

How to test

git clone -b drop-loadsh-for-plugins-console-deploy https://github.com/SukkaW/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage decreased (-0.002%) to 97.266% when pulling c8d0786 on SukkaW:drop-loadsh-for-plugins-console-deploy into 9ba38e9 on hexojs:master.

@SukkaW SukkaW requested review from segayuu, curbengh and YoshinoriN Oct 21, 2019
@SukkaW SukkaW added this to In progress in Replace lodash with native API via automation Oct 21, 2019
@SukkaW SukkaW moved this from In progress to To do in Replace lodash with native API Oct 21, 2019
@SukkaW SukkaW moved this from To do to In progress in Replace lodash with native API Oct 21, 2019
@tomap
tomap approved these changes Oct 22, 2019
@SukkaW SukkaW merged commit 94b4692 into hexojs:master Oct 27, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.002%) to 97.266%
Details
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Replace lodash with native API automation moved this from In progress to Done Oct 27, 2019
@SukkaW SukkaW mentioned this pull request Oct 28, 2019
16 of 16 tasks complete
oncletom added a commit to oncletom/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.