Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toc_helper): replace lodash with hexo-util #3786

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 21, 2019

What does it do?

This PR is a part of #3753

How to test

git clone -b drop-loadsh-for-toc-helper https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@SukkaW SukkaW requested review from segayuu and curbengh Oct 21, 2019
@SukkaW SukkaW changed the title refactor(toc_helper): relpace lodash with hexo-util refactor(toc_helper): replace lodash with hexo-util Oct 21, 2019
@SukkaW SukkaW force-pushed the SukkaW:drop-loadsh-for-toc-helper branch from b8ee1bf to 68f4303 Oct 21, 2019
@SukkaW SukkaW added this to In progress in Replace lodash with native API via automation Oct 21, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage remained the same at 97.267% when pulling 68f4303 on SukkaW:drop-loadsh-for-toc-helper into 9ba38e9 on hexojs:master.

@SukkaW SukkaW moved this from In progress to To do in Replace lodash with native API Oct 21, 2019
@SukkaW SukkaW moved this from To do to In progress in Replace lodash with native API Oct 21, 2019
@tomap
tomap approved these changes Oct 22, 2019
@segayuu segayuu merged commit 7e48df3 into hexojs:master Oct 22, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 97.267%
Details
Replace lodash with native API automation moved this from In progress to Done Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.