Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(date_helper): drop lodash #3788

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 23, 2019

What does it do?

This PR is a part of #3753

How to test

git clone -b drop-lodash-for-date-helper https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@SukkaW SukkaW requested review from tomap, segayuu and curbengh Oct 23, 2019
@SukkaW SukkaW added this to To do in Replace lodash with native API via automation Oct 23, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 23, 2019

Coverage Status

Coverage increased (+0.002%) to 97.269% when pulling 207f0ce on SukkaW:drop-lodash-for-date-helper into 7e48df3 on hexojs:master.

Replace lodash with native API automation moved this from To do to In progress Oct 23, 2019
@segayuu segayuu merged commit d8ec214 into hexojs:master Oct 23, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.002%) to 97.269%
Details
Replace lodash with native API automation moved this from In progress to Done Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.