Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop lodash for post_permalink filter #3790

Merged
merged 1 commit into from Oct 27, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 23, 2019

What does it do?

This PR is a part of #3753

How to test

git clone -b drop-lodash-for-post_permalink-filter https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@SukkaW SukkaW requested review from segayuu and curbengh Oct 23, 2019
@SukkaW SukkaW added this to To do in Replace lodash with native API via automation Oct 23, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 23, 2019

Coverage Status

Coverage decreased (-0.002%) to 97.268% when pulling 244e8c9 on SukkaW:drop-lodash-for-post_permalink-filter into d8ec214 on hexojs:master.

Replace lodash with native API automation moved this from To do to In progress Oct 26, 2019
@SukkaW SukkaW merged commit e0f2478 into hexojs:master Oct 27, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.002%) to 97.268%
Details
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Replace lodash with native API automation moved this from In progress to Done Oct 27, 2019
oncletom added a commit to oncletom/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.