Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backtick_code): replace cloneDeep with Object.assign() #3826

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Nov 2, 2019

What does it do?

Part of #3753

How to test

git clone -b refactor-clonedeep https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@curbengh curbengh added this to To do in Replace lodash with native API via automation Nov 2, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 2, 2019

Coverage Status

Coverage remained the same at 97.141% when pulling 12a43ef on curbengh:refactor-clonedeep into b2a71e7 on hexojs:master.

@seaoak
seaoak approved these changes Nov 5, 2019
Copy link
Member

seaoak left a comment

LGTM since the target is a plain JavaScript object.

Replace lodash with native API automation moved this from To do to In progress Nov 5, 2019
@SukkaW
SukkaW approved these changes Nov 6, 2019
@SukkaW SukkaW merged commit 1b69a53 into hexojs:master Nov 8, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 97.141%
Details
Replace lodash with native API automation moved this from In progress to Done Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.