Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code of Conduct #3962

Merged
merged 2 commits into from Dec 30, 2019
Merged

Add Code of Conduct #3962

merged 2 commits into from Dec 30, 2019

Conversation

tommy351
Copy link
Member

What does it do?

Netlify recently updated their policy. It is required to have a Code of Conduct in the repository.

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 14, 2019 •
edited

Coverage Status

Coverage decreased (-0.007%) to 97.131% when pulling d851678 on add-code-of-conduct-1 into e4a5292 on master.

@tommy351 tommy351 requested a review from a team December 14, 2019 08:56
SukkaW
SukkaW reviewed Dec 14, 2019
View reviewed changes
CODE_OF_CONDUCT.md Outdated
## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at hi@hexo.io. All
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a dedicated email address could be used, like abuse@hexo.io or report@hexo.io?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoahDragon mentioned about mail forward, not sure the current status.

SukkaW
SukkaW previously approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

curbengh
curbengh previously approved these changes Dec 14, 2019
View reviewed changes
@tomap
Copy link
Contributor

tomap commented Dec 14, 2019

Quick question: you used the v1.4. but there is a v2 available. Why not use it?
https://www.contributor-covenant.org/version/2/0/code_of_conduct

MD: https://www.contributor-covenant.org/version/2/0/code_of_conduct.md

@tommy351
Copy link
Member Author

@tomap This pull request is created by the template on GitHub. I didn't know there's a newer version of CoC.

yoshinorin
yoshinorin reviewed Dec 14, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you mention it on the README?

@SukkaW
Copy link
Member

SukkaW commented Dec 14, 2019

@yoshinorin Agree. We should add the link of Code of Conduct at the beginning the README, just as Node.js do in their README.

segayuu
segayuu previously approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommy351
docs: Update code of conduct and readme
d851678 
- Update the contact method to "report@hexo.io"
- Update the code of conduct to Contributor Covenant v2.0
- Add links to the code of conduct in readme
@tommy351 tommy351 dismissed stale reviews from segayuu, curbengh, and SukkaW via d851678 December 15, 2019 08:18
@tommy351
Copy link
Member Author

tommy351 commented Dec 15, 2019 •
edited by SukkaW

I updated the code of conduct and readme in d851678

Here I list some items to do before we merged:

  • Make sure report@hexo.io is available.
  • Make sure reports sent to the email address can be handled.
  • Add the link of CoC to the contribution guide as well.

@curbengh
Copy link
Contributor

curbengh commented Dec 15, 2019 •
edited

Quick question: you used the v1.4. but there is a v2 available. Why not use it?
https://www.contributor-covenant.org/version/2/0/code_of_conduct

I thought OP just adapt from Babel project (who still using v1.4). I find v2 a bit harsh, but I can live with it.

@tcrowe
Copy link
Contributor

tcrowe commented Dec 19, 2019 •
edited

For people searching in the future, if you want to know how hexo org deals with abuse of contributors please view my analysis here: https://github.com/tcrowe/code-communists/blob/master/projects/hexo/index.md

I was a contributor who was taking a break. My plan was to come back and work on hexo more but I've removed myself from the hexo org over this issue.

NoahDragon
NoahDragon approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SukkaW
Copy link
Member

SukkaW commented Dec 30, 2019

@NoahDragon Please help setting up report@hexo.io email address at mailgun. Every "owner" of hexojs organization should be able to receive related complaint email.

@NoahDragon
Copy link
Member

@SukkaW That's a good idea. I have created the email address report[at]hexo.io.
@hexojs/core By default, the email only forwards to owners, but core members could also join voluntarily. Just shot an email to the above address if you would like to be involved.

@SukkaW
Copy link
Member

SukkaW commented Dec 30, 2019 •
edited

@tommy351 Since the email address report at hexo.io is now up, I believe it is ok to merge this PR then. I will add the link of Code of Conduct to contributing guideline later.

@SukkaW SukkaW merged commit 663f1eb into master Dec 30, 2019
@tommy351
Copy link
Member Author

tommy351 commented Jan 2, 2020

圖片

Quick update: We are re-qualified for the open source plan now. 🎉

thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@tommy351
docs: Code of Conduct (hexojs#3962)
2cc749e 
* Create CODE_OF_CONDUCT.md

* docs: Update code of conduct and readme

- Update the contact method to "report@hexo.io"
- Update the code of conduct to Contributor Covenant v2.0
- Add links to the code of conduct in readme
@stevenjoezhang stevenjoezhang deleted the add-code-of-conduct-1 branch April 26, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin left review comments

@tomap tomap tomap approved these changes

@ertrzyiks ertrzyiks ertrzyiks approved these changes

@NoahDragon NoahDragon NoahDragon approved these changes

@SukkaW SukkaW SukkaW approved these changes

@curbengh curbengh curbengh approved these changes

@segayuu segayuu segayuu left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@tommy351 @coveralls @tomap @SukkaW @curbengh @tcrowe @NoahDragon @ertrzyiks @segayuu @yoshinorin