Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toc): avoid using htmlTag #4183

Merged
merged 1 commit into from Mar 12, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Mar 11, 2020

What does it do?

Fix #4181, an alternative to #4182.

By avoid using over complicated htmlTag() to gain better performance and fit the current test cases.

How to test

git clone -b refactor/og-remove-htmltag https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from seaoak and curbengh March 11, 2020 14:41
@SukkaW
Copy link
Member Author

SukkaW commented Mar 11, 2020

The benchmark performed by Travis CI shows the PR help improved generating speed by 4%.

Copy link
Member

@seaoak seaoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SukkaW SukkaW merged commit d835578 into hexojs:master Mar 12, 2020
stevenjoezhang added a commit to next-theme/hexo-theme-next that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm test failed for toc helper
2 participants