New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blank lines for #792 #774 #795

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@0ssifrage

0ssifrage commented Aug 14, 2014

@tommy351 wrapped each line with <div class="line"> to fix #687, however, there was a problem with codes with blank lines just like #792 and #774.

Adding css style for .line may be a solution, but it's hard to let all the themes change their css files, I think using span instead of div and adding \n for each line can fix this issue without changing the css files, but I am not sure whether it will cause the same problem in #687. (I don't have the same problem in that issue before wrapping the line with div).

@wzpan

This comment has been minimized.

Show comment
Hide comment
@wzpan

wzpan Sep 16, 2014

Member

This patch is good. I highly recommend to merge it.

Member

wzpan commented Sep 16, 2014

This patch is good. I highly recommend to merge it.

@leesei

This comment has been minimized.

Show comment
Hide comment
@leesei

leesei Jul 16, 2015

Member

Fixed in 3.0.

Member

leesei commented Jul 16, 2015

Fixed in 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment