Sorry for resulting in the site down for about 2 hours #134

Closed
Xuanwo opened this Issue Dec 10, 2015 · 4 comments

Projects

None yet

3 participants

@Xuanwo
Member
Xuanwo commented Dec 10, 2015

Hello, everyone, I'm @Xuanwo, and I made a mistake today morning which made the dite down for about 2 hours.
Thank @zhangwenan 's report, ref hexojs/hexo#1642 , I convert my commit and rebuild the site, but because the site use cloudflare as CDN, so until now, the site may still have some problem.

That's all. And this mistake makes me think more.

We should modify the build script that when we meet an error, we should stop the build instead of uploading the wrong page. I will pull a request late about this.

ref: https://travis-ci.org/hexojs/site/builds/95942765

I hope my mistake will not lead to a disaster, 😞 .

@Xuanwo Xuanwo added the bug label Dec 10, 2015
@Xuanwo
Member
Xuanwo commented Dec 11, 2015

@tommy351 If error happened in https://github.com/hexojs/site/blob/master/.travis/deploy.sh#L18 , travis ci will not return non zero exit code which will result in wrong deploy.

@leesei
Member
leesei commented Dec 11, 2015

No problem. I don't think any cat died in this incident.

That's weird, it seems hexo did not exit with error code upon this failure.

@tommy351
Member
tommy351 commented Jan 3, 2016

It's a bug of hexo-cli and it's fixed in 0.2.0. hexo-cli 0.2 will be shipped in hexo 3.2.

@tommy351 tommy351 closed this Jan 3, 2016
@Xuanwo
Member
Xuanwo commented Jan 3, 2016

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment