Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[BREAKING CHANGE] Replace constructor function to class declaration #30
tcrowe left a comment
In the future please provide:
We should also include something like this in a PR template across the repos where there is time.
It changes all the modules to use ES6
How to test:
git clone -b replace-class https://github.com/segayuu/warehouse.git cd warehouse npm install npm test
I found a problem integrating it with https://github.com/hexojs/hexo.
git clone -b replace-class https://github.com/segayuu/warehouse.git cd warehouse npm install cd .. git clone https://github.com/hexojs/hexo.git cd hexo npm install npm rm warehouse npm install ../warehouse npm test
The result is this error:
@segayuu Maybe you can advise me here. Unless I did something wrong we may need to adjust other modules for compatibility.
I appreciate @tcrowe 's review!
This error message is not a bug.
Either way, the
I think, following procedure is better way for migrate warehouse repository to class declaration.
I think hexo's core repositories should to be migrate ES6 step by step.