Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert method definitions #52

Merged
merged 7 commits into from Sep 7, 2019

Conversation

@segayuu
Copy link
Contributor

commented Jul 25, 2019

This PR is for conversion to method definition only, because there are many differences in git.
Automatic conversion in lebab does not occur if the constructor is defined in a class declaration.
The first purpose of Revert is to reduce manual conversion.

@segayuu segayuu requested a review from hexojs/core Jul 25, 2019
@segayuu segayuu added this to the v3.0.0 milestone Jul 25, 2019
@segayuu segayuu force-pushed the segayuu:Convert-method-definitions branch 2 times, most recently from 5284bf7 to c72cbfd Aug 29, 2019
…nvert-method-definitions
@segayuu segayuu force-pushed the segayuu:Convert-method-definitions branch from c72cbfd to 1c5c81e Aug 30, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Just curious, would https://github.com/hexojs/hexo/blob/master/lib/hexo/post.js (and others) benefit from refactor to this style?

@segayuu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

If you reference hexo.model(), hexo.locals or hexo.database, you will benefit from it.

@segayuu segayuu merged commit 109151a into hexojs:master Sep 7, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.3%) to 96.402%
Details
Travis CI - Pull Request Build Passed
Details
@segayuu segayuu deleted the segayuu:Convert-method-definitions branch Sep 7, 2019
@curbengh curbengh referenced this pull request Oct 20, 2019
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.