Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Schema class #58

Merged
merged 5 commits into from Sep 26, 2019

Conversation

@segayuu
Copy link
Contributor

commented Sep 12, 2019

I think it's obvious to everyone that the Schema class is complicated.
However, the Schema class can be split without changing the behavior.
About half of the methods in the Schema class can be divided into classes to clarify responsibilities.

@segayuu segayuu requested a review from hexojs/core Sep 12, 2019
fix
@segayuu segayuu merged commit 329016c into hexojs:master Sep 26, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.2%) to 96.564%
Details
@segayuu segayuu deleted the segayuu:Split-schema-parser branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.