Change publish package message on non-default api_url #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Dec 1, 2019
| to_repository = | ||
| cond do | ||
| !organization and non_default_api_url? -> | ||
| "" |
There was a problem hiding this comment.
this is so that when someone uses an external repo (like mini_repo) they don't get a message that we're publishing to hexpm when no organisation is set.
wojtekmach
changed the title
ericmj
approved these changes
Dec 2, 2019
lib/mix/tasks/hex.publish.ex
Outdated
| ]) | ||
| end | ||
| api_url = Hex.State.fetch!(:api_url) | ||
| non_default_api_url? = api_url != Hex.State.default_api_url() |
There was a problem hiding this comment.
I think it will read better if the variable name is not negated: default_api_url? = api_url == Hex.State.default_api_url().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #721