Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Broadway #11

Merged
merged 4 commits into from Jul 25, 2019

Conversation

@wojtekmach
Copy link
Member

commented Jul 15, 2019

No description provided.


@bucket :docs_private_bucket
@public_bucket :docs_public_bucket

setup do
Mox.set_mox_global()

This comment has been minimized.

Copy link
@wojtekmach

wojtekmach Jul 15, 2019

Author Member

this is needed because now we're testing it through the pipeline so the consumer code is executed in a separate process.

@wojtekmach wojtekmach force-pushed the wm-broadway branch from dd065d8 to b7c868a Jul 15, 2019
@wojtekmach

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

@ericmj this is ready for review and has been successfully running on staging. The only missing piece is to wait for a new Broadway release with improvements that came out of working on this :)

Copy link
Member

left a comment

Beautiful! I only have some questions.

Plug.Cowboy.child_spec(scheme: :http, plug: Hexdocs.Plug, options: [port: port])
end
cowboy_options = [port: port]
Logger.info("Running Cowboy with #{inspect(cowboy_options)}")

This comment has been minimized.

Copy link
@ericmj
lib/hexdocs/queue.ex Show resolved Hide resolved
message
|> Broadway.Message.update_data(&Jason.decode!/1)
|> handle_message()
end

This comment has been minimized.

Copy link
@ericmj

ericmj Jul 24, 2019

Member

So much more concise 😍

{:plug_cowboy, "~> 2.0"},
{:rollbax, "~> 0.9.2"},
{:sweet_xml, "~> 0.6.5"}
{:sweet_xml, "~> 0.6.5"},

This comment has been minimized.

Copy link
@ericmj

ericmj Jul 24, 2019

Member

mix format? Should we add it to CI?

This comment has been minimized.

Copy link
@wojtekmach

wojtekmach Jul 24, 2019

Author Member

Yup, I will fix it here and add to CI on master.

@ericmj
ericmj approved these changes Jul 25, 2019
Copy link
Member

left a comment

Everything looks good, and please add CI to master 🙏

@wojtekmach wojtekmach merged commit 140c5fe into master Jul 25, 2019
3 checks passed
3 checks passed
Build (138366431608) Summary
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@wojtekmach wojtekmach deleted the wm-broadway branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.