New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept database specification for all environments #86

Merged
merged 1 commit into from Jan 11, 2015

Conversation

Projects
None yet
2 participants
@joeyates
Contributor

joeyates commented Jan 9, 2015

  • users can override the default database name, username and password
    when in dev and test mode by setting environment variables,
    • for dev, set DEV_DATABASE_URL,
    • for test, set TEST_DATABASE_URL,
  • the variables are different so that tests can be run against a
    different database to the one used for dev,
  • as tests need to be run via a single pooled connection, the test
    params have size=1 and max_overflow=0 set as overrides.
Accept database specification for all environments
* users can override the default database name, username and password
  when in dev and test mode by setting environment variables,
  * for dev, set DEV_DATABASE_URL,
  * for test, set TEST_DATABASE_URL,
* the variables are different so that tests can be run against a
  different database to the one used for dev,
* as tests need to be run via a single pooled connection, the test
  params have size=1 and max_overflow=0 set as overrides.

ericmj added a commit that referenced this pull request Jan 11, 2015

Merge pull request #86 from joeyates/feature/permit_database_config
Accept database specification for all environments

@ericmj ericmj merged commit 18a63c3 into hexpm:master Jan 11, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment