Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace HexpmWeb.ViewHelpers import with an alias #887
Conversation
This comment has been minimized.
This comment has been minimized.
|
This is really great. Did you do any benchmarks or tests to see if this improved number of recompiled modules or recompilation time? |
This comment has been minimized.
This comment has been minimized.
|
I sure did, here are the results, before:
after:
Clearly there's more work to be done, but that's a step in the right direction. We have a similar issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wojtekmach commentedJan 15, 2020
•
edited
To do this I used a small tool I was working on recently, import2alias.exs:
mix run import2alias.exs Hexpm.ViewHelpers ViewHelpers. More info about that soon-ish, I'm planning to write up a blog post about it with some additional background information.