Add url to middleware Options type

[snarky-puppy]

Description

url starts out in Options but later gets Omitted here

export type Options<
  T extends { url: string } = { url: string },
  ThrowOnError extends boolean = boolean,
> = T extends { body?: any }
  ? T extends { headers?: any }
    ? OmitKeys<OptionsBase<ThrowOnError>, 'body' | 'headers'> & Omit<T, 'url'>
...

I can't really figure out why, does anyone know?

It would be useful for me to build a rate limiting middleware using the pre-processed url. The rate limiter is per endpoint so I can't use the processed url (i.e. I need /users/{userId} and not /users/123)

Currently using this code to extract the url anyway...

import {Options} from '@hey-api/client-fetch';

const myMiddleware = (request: Request, config: Options) => {
  const url = (config as {url: string}).url;
  ...

[mrlubos]

Hey @snarky-puppy, the main use case for Options is to type the SDK functions where you don't want to pass the URL every time. I'll need to clean this up for your use case. To clarify, the URL is actually passed as needed, it's just types that need to be improved?

[snarky-puppy]

Hey @mrlubos, ok that makes sense, I guess maybe a different Options type for middleware is needed?

FWIW I'm using the fetch-client and I can see the generated url isn't passed in via options, only the url from the SDK.