diff --git a/.github/workflows/catalog-previews.yml b/.github/workflows/catalog-previews.yml index 9640140a79..1822e7683b 100644 --- a/.github/workflows/catalog-previews.yml +++ b/.github/workflows/catalog-previews.yml @@ -58,6 +58,14 @@ jobs: with: chrome-version: stable + # The renderer shells out to ffmpeg for both halves of a preview: the + # poster transcode and the web encode of the mp4. Neither ran here before + # (`--skip-video` skipped the encode, and the poster copy was a plain + # file copy), so the job never needed it and ubuntu-latest does not ship + # it. + - name: Install ffmpeg + run: sudo apt-get update -qq && sudo apt-get install -y --no-install-recommends ffmpeg + - name: Render changed block/component previews env: BASE_SHA: ${{ github.event.pull_request.base.sha }} @@ -68,6 +76,19 @@ jobs: | sed 's|^registry/[^/]*/\([^/]*\)/.*|\1|' \ | sort -u) + # A renderer change reaches every item, so it cannot be trusted to a + # PR that happens to also touch a block. Two canaries cover the two + # shapes the renderer has to tell apart: a block whose scene lives in + # a