Skip to content

Compatibility with igraph 2.0.0 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krlmlr opened this issue Dec 31, 2023 · 7 comments
Closed

Compatibility with igraph 2.0.0 #148

krlmlr opened this issue Dec 31, 2023 · 7 comments
Assignees
Labels
bug errors that occurred within the package

Comments

@krlmlr
Copy link

krlmlr commented Dec 31, 2023

@AlexChristensen @hfgolino: This package fails its checks for the release candidate for igraph 2.0.0. See https://github.com/igraph/rigraph/blob/main/revdep/problems.md for details.

Is this a problem in your package? Should we be doing things differently?

Install the 2.0.0 release candidate using pak::pak("igraph/rigraph") .

We're planning to release igraph 2.0.0 in mid-January. Thank you for your help!

Tracker: igraph/rigraph#989.

@krlmlr krlmlr added the bug errors that occurred within the package label Dec 31, 2023
AlexChristensen added a commit that referenced this issue Jan 1, 2024
o Through `ellipse`, `resolution_parameter` was passed through to {igraph}'s `cluster_leiden` twice

o Resolved by removing excessive `ellipse` call

o Confirmed on check that error does not occur with latest {igraph} update #148
@AlexChristensen
Copy link
Collaborator

@krlmlr, confirmed that issue was on our end

Ran checks with the {igraph} 2.0.0 release candidate and did not identify any other issues -- you should be good to go

I'll leave this issue open until there is confirmation on your end

Thanks!

@krlmlr
Copy link
Author

krlmlr commented Jan 1, 2024

Thanks. From a very coarse look, it seems like the most recent change fixes the symptoms but also loses functionality. What was the purpose of the extra arguments to EGA.estimate() that were stored in ellipse ? If this is truly intended, is it really necessary to update the ellipse variable in 3f276b2?diff=split&w=1#diff-a57242e662fa0e51754e8df3591f3490e5e8d3a3e34bf2a1fc9e7466b4d170ffR664 ?

Either way, I'd appreciate if you could send an update to CRAN when it reopens.

@AlexChristensen
Copy link
Collaborator

Thanks for the quick look -- you're correct that the previous remedy lost some functionality. Just implemented a proper fix that maintains functionality

We will plan for an update to CRAN next week

@hfgolino
Copy link
Owner

hfgolino commented Jan 1, 2024 via email

@krlmlr
Copy link
Author

krlmlr commented Jan 21, 2024

We're planning to send igraph to CRAN on January 23, we're still seeing failures with this package: https://github.com/igraph/rigraph/blob/main/revdep/problems.md .

@hfgolino
Copy link
Owner

hfgolino commented Jan 21, 2024 via email

@AlexChristensen
Copy link
Collaborator

Closing as {igraph} has been updated and no dependency issues remain: https://cran.r-project.org/package=igraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug errors that occurred within the package
Projects
None yet
Development

No branches or pull requests

3 participants