-
Notifications
You must be signed in to change notification settings - Fork 9
Compatibility with igraph 2.0.0 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@krlmlr, confirmed that issue was on our end Ran checks with the {igraph} 2.0.0 release candidate and did not identify any other issues -- you should be good to go I'll leave this issue open until there is confirmation on your end Thanks! |
Thanks. From a very coarse look, it seems like the most recent change fixes the symptoms but also loses functionality. What was the purpose of the extra arguments to Either way, I'd appreciate if you could send an update to CRAN when it reopens. |
Thanks for the quick look -- you're correct that the previous remedy lost some functionality. Just implemented a proper fix that maintains functionality We will plan for an update to CRAN next week |
Thanks for your message, Kirill.
We'll make all changes as you suggested, and submit a new version of the
package to CRAN ASAP.
Cheers,
Hudson
*Hudson Golino*
*Associate Professor*
*Department of Psychology*
*E* ***@***.*** ***@***.***>
*University of Virginia*
1023 Millmont St, Office 115
Charlottesville, VA 22903
Em seg., 1 de jan. de 2024 às 10:07, Alexander Christensen <
***@***.***> escreveu:
… Thanks for the quick look -- you're correct that the previous remedy lost
some functionality. Just implemented a proper fix that maintains
functionality
We will plan for an update to CRAN next week
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFLKG2MHPAFYQMUTHVH6TTYMKYJHAVCNFSM6AAAAABBIQDEK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGMZDCMRQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
We're planning to send igraph to CRAN on January 23, we're still seeing failures with this package: https://github.com/igraph/rigraph/blob/main/revdep/problems.md . |
Awesome, thanks for the heads up!
…On Sun, Jan 21, 2024, 4:33 AM Kirill Müller ***@***.***> wrote:
We're planning to send igraph to CRAN on January 23.
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFLKG3B5K4D36HJYRFWSRLYPTOGJAVCNFSM6AAAAABBIQDEK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU3DSMBSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closing as {igraph} has been updated and no dependency issues remain: https://cran.r-project.org/package=igraph |
@AlexChristensen @hfgolino: This package fails its checks for the release candidate for igraph 2.0.0. See https://github.com/igraph/rigraph/blob/main/revdep/problems.md for details.
Is this a problem in your package? Should we be doing things differently?
Install the 2.0.0 release candidate using
pak::pak("igraph/rigraph")
.We're planning to release igraph 2.0.0 in mid-January. Thank you for your help!
Tracker: igraph/rigraph#989.
The text was updated successfully, but these errors were encountered: