New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to WebExtensions #39

Closed
hfiguiere opened this Issue Aug 22, 2015 · 10 comments

Comments

Projects
None yet
3 participants
@hfiguiere
Owner

hfiguiere commented Aug 22, 2015

Use the new WebExtensions API.

@ssokolow

This comment has been minimized.

Show comment
Hide comment
@ssokolow

ssokolow Mar 6, 2017

This is a bit of a pressing concern, given that Firefox 57 will disable support for XUL extensions.

If nothing else, now is the time to double-check that the WebExtensions APIs offered are sufficient, so there's still time to file feature requests and have them go through design and implementation before Firefox 57 enters Aurora channel in August.

ssokolow commented Mar 6, 2017

This is a bit of a pressing concern, given that Firefox 57 will disable support for XUL extensions.

If nothing else, now is the time to double-check that the WebExtensions APIs offered are sufficient, so there's still time to file feature requests and have them go through design and implementation before Firefox 57 enters Aurora channel in August.

@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Mar 7, 2017

Owner

This is not a XUL extension. It uses the Add-on SDK (né Jetpack). I believe the porting effort might be minimal but it is my understanding that using the SDK this way is safe.

Owner

hfiguiere commented Mar 7, 2017

This is not a XUL extension. It uses the Add-on SDK (né Jetpack). I believe the porting effort might be minimal but it is my understanding that using the SDK this way is safe.

@ssokolow

This comment has been minimized.

Show comment
Hide comment
@ssokolow

ssokolow Mar 7, 2017

The way I heard it, Firefox 57 will refuse to run anything that isn't a WebExtension. Do you have a source for your interpretation?

(I was including Add-on SDK under "XUL extensions" because, before it was bundled with Firefox, it was just an abstraction library you had to bundle into your XPI yourself.)

ssokolow commented Mar 7, 2017

The way I heard it, Firefox 57 will refuse to run anything that isn't a WebExtension. Do you have a source for your interpretation?

(I was including Add-on SDK under "XUL extensions" because, before it was bundled with Firefox, it was just an abstraction library you had to bundle into your XPI yourself.)

@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Mar 7, 2017

Owner

Most of no-flash features, ie rewriting YouTube Flash embed, are now in Firefox. (I didn't take any part in this)

Owner

hfiguiere commented Mar 7, 2017

Most of no-flash features, ie rewriting YouTube Flash embed, are now in Firefox. (I didn't take any part in this)

@ssokolow

This comment has been minimized.

Show comment
Hide comment
@ssokolow

ssokolow Mar 7, 2017

That's good to hear.

As long as I don't experience any disruption when Firefox 57 rolls around, I'll be happy.

ssokolow commented Mar 7, 2017

That's good to hear.

As long as I don't experience any disruption when Firefox 57 rolls around, I'll be happy.

@ssokolow

This comment has been minimized.

Show comment
Hide comment
@ssokolow

ssokolow Mar 7, 2017

For the record, I just confirmed. The latest Mozilla communication I'm aware of says as follows:

Firefox 57, November 14th release

Firefox will only run WebExtensions.

(I went on IRC to confirm that the change is tied to the Firefox 57 codebase, rather than the date, so it'll appear earlier in pre-stable release channels.)

ssokolow commented Mar 7, 2017

For the record, I just confirmed. The latest Mozilla communication I'm aware of says as follows:

Firefox 57, November 14th release

Firefox will only run WebExtensions.

(I went on IRC to confirm that the change is tied to the Firefox 57 codebase, rather than the date, so it'll appear earlier in pre-stable release channels.)

@gerv

This comment has been minimized.

Show comment
Hide comment
@gerv

gerv Jun 30, 2017

@hfiguiere: are you saying that this extension is no longer necessary because most of its functionality is built into Firefox?

gerv commented Jun 30, 2017

@hfiguiere: are you saying that this extension is no longer necessary because most of its functionality is built into Firefox?

@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Aug 17, 2017

Owner

There are many cases where the Firefox embed rewrite do not work.

But at the moment this extension no longer do anything because it no longer get the event PluginBindingAttached. And I don't know yet how I can get an equivalent in the WebExtension API.

Owner

hfiguiere commented Aug 17, 2017

There are many cases where the Firefox embed rewrite do not work.

But at the moment this extension no longer do anything because it no longer get the event PluginBindingAttached. And I don't know yet how I can get an equivalent in the WebExtension API.

@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Aug 17, 2017

Owner

Also it support Vimeo and and Dailymotion

Owner

hfiguiere commented Aug 17, 2017

Also it support Vimeo and and Dailymotion

hfiguiere added a commit that referenced this issue Aug 17, 2017

Bug #39 - Port to WebExtension
- Refactor code
- Revert to the old method for finding elements to rewrite
- Move content script.
@hfiguiere

This comment has been minimized.

Show comment
Hide comment
@hfiguiere

hfiguiere Aug 17, 2017

Owner

Current master works as a WebExtension.

Owner

hfiguiere commented Aug 17, 2017

Current master works as a WebExtension.

@hfiguiere hfiguiere closed this Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment