Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json is missing #1

Closed
mickeyvip opened this issue Nov 23, 2016 · 3 comments
Closed

package.json is missing #1

mickeyvip opened this issue Nov 23, 2016 · 3 comments

Comments

@mickeyvip
Copy link

this repo by itself is unusable since it is missing several config files, such as package.json

@hggeorgiev
Copy link
Owner

package.json is not missing . Are you using angular-cli to build the project?

@mickeyvip
Copy link
Author

mickeyvip commented Nov 23, 2016

Yes, I am using angular-cli and I have package.json generated automatically. I mean it is missing from this repo.

The reason I am pointing this out is because not all code snippets worked for me and I wanted to know what version of @ngrx/store were used in the article.

Specifically:

image

[default] /Users/michaelv/dev/IdeaProjects/financials-app/src/app/common/operations.ts:12:21
    Generic type 'State<T>' requires 1 type argument(s).

image

[default] /Users/me/financials-app/src/app/common/operations.ts:16:33
    Generic type 'ActionReducer<T>' requires 1 type argument(s).
[default] Checking finished with 2 errors

plus, inside operationsReducer there are multiple const operation = inside case statements, producing:

[default] /Users/me/financials-app/src/app/common/operations.ts:25:19
    Cannot redeclare block-scoped variable 'operation'.

my versions:

financials-app@0.0.0 /Users/me/financials-app
├── @angular/common@2.2.1
├── @angular/compiler@2.2.1
├── @angular/compiler-cli@2.2.1
├── @angular/core@2.2.1
├── @angular/forms@2.2.1
├── @angular/http@2.2.1
├── @angular/platform-browser@2.2.1
├── @angular/platform-browser-dynamic@2.2.1
├── @angular/router@3.2.1
├── @ngrx/core@1.2.0
├── @ngrx/store@2.2.1
├── @types/jasmine@2.5.38
├── @types/node@6.0.48
├── angular-cli@1.0.0-beta.20-4
├── bootstrap@4.0.0-alpha.5
├── codelyzer@1.0.0-beta.4
├── core-js@2.4.1
├── jasmine-core@2.4.1
├── jasmine-spec-reporter@2.5.0
├── karma@1.2.0
├── karma-chrome-launcher@2.0.0
├── karma-cli@1.0.1
├── karma-jasmine@1.0.2
├── karma-remap-istanbul@0.2.1
├── protractor@4.0.9
├── rxjs@5.0.0-beta.12
├── ts-helpers@1.1.2
├── ts-node@1.2.1
├── tslint@3.13.0
├── typescript@2.0.10
├── webdriver-manager@10.2.5
└── zone.js@0.6.26

@mickeyvip
Copy link
Author

Other than that - The article is very good, I have learned a lot.

And it has the best visualization of Redux process I have ever seen!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants