Permalink
Commits on Jun 21, 2016
  1. bug #19126 [PhpUnitBridge] use call_user_func() for PHP 5.3 compatibi…

    …lity (xabbuh)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Not all callables can be called directly on PHP 5.3 (for example, `array('className', 'methodName')` does not work).
    
    Commits
    -------
    
    8549e05 use call_user_func() for PHP 5.3 compatibility
    fabpot committed Jun 21, 2016
  2. use call_user_func() for PHP 5.3 compatibility

    Not all callables can be called directly on PHP 5.3 (for example,
    `array('className', 'methodName')` does not work).
    xabbuh committed Jun 21, 2016
  3. fixed CS

    fabpot committed Jun 21, 2016
  4. Merge branch '3.1'

    * 3.1:
      fixed CS
      fixed CS
      fixed CS
      fixed CS
      tweaked default CS fixer config
      [HttpKernel] Dont close the output stream in debug
      move HttpKernel component to require section
      Fixed oci and sqlsrv merge queries when emulation is disabled - fixes #17284
      [Session] fix PDO transaction aborted under PostgreSQL
      [Console] Use InputInterface inherited doc as possible
      Mention generating absolute urls in UPGRADE files and CHANGELOG
      parse embedded mappings only if value is a string
      add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
      FormBuilderInterface: fix getForm() return type.
      [YAML] Fixed parsing problem with nested DateTime lists
      Fixed typo in PHPDoc
    fabpot committed Jun 21, 2016
  5. minor #19124 fixed CS (fabpot)

    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    fixed CS
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    I submit this one to check that everyone is ok to NOT mix short array notations with long array notations in Symfony even in 3.x. Consistency is better IMHO.
    
    Commits
    -------
    
    a39afd0 fixed CS
    fabpot committed Jun 21, 2016
  6. Revert "feature #18977 [PropertyAccess] Add missing arguments to Prop…

    …ertyAccess::createPropertyAccessor() (chalasr)"
    
    This reverts commit 86eb7a3, reversing
    changes made to 856c9f6.
    fabpot committed Jun 21, 2016
  7. Revert "minor #19030 [PropertyAccess] add missing argument PHPdoc (xa…

    …bbuh)"
    
    This reverts commit 3844fb9, reversing
    changes made to e188cd7.
    fabpot committed Jun 21, 2016
  8. fixed CS

    fabpot committed Jun 21, 2016
  9. Merge branch '3.0' into 3.1

    * 3.0:
      fixed CS
      fixed CS
      fixed CS
      tweaked default CS fixer config
      [HttpKernel] Dont close the output stream in debug
      move HttpKernel component to require section
      Fixed oci and sqlsrv merge queries when emulation is disabled - fixes #17284
      [Session] fix PDO transaction aborted under PostgreSQL
      [Console] Use InputInterface inherited doc as possible
      Mention generating absolute urls in UPGRADE files and CHANGELOG
      add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
      FormBuilderInterface: fix getForm() return type.
      Fixed typo in PHPDoc
    fabpot committed Jun 21, 2016
  10. fixed CS

    fabpot committed Jun 21, 2016
  11. Merge branch '2.8' into 3.0

    * 2.8:
      fixed CS
      fixed CS
      tweaked default CS fixer config
      [HttpKernel] Dont close the output stream in debug
      move HttpKernel component to require section
      Fixed oci and sqlsrv merge queries when emulation is disabled - fixes #17284
      [Session] fix PDO transaction aborted under PostgreSQL
      [Console] Use InputInterface inherited doc as possible
      Mention generating absolute urls in UPGRADE files and CHANGELOG
      add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
      FormBuilderInterface: fix getForm() return type.
      Fixed typo in PHPDoc
    fabpot committed Jun 21, 2016
  12. fixed CS

    fabpot committed Jun 21, 2016
  13. Merge branch '2.7' into 2.8

    * 2.7:
      fixed CS
      tweaked default CS fixer config
      [HttpKernel] Dont close the output stream in debug
      move HttpKernel component to require section
      Fixed oci and sqlsrv merge queries when emulation is disabled - fixes #17284
      [Session] fix PDO transaction aborted under PostgreSQL
      [Console] Use InputInterface inherited doc as possible
      add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
      FormBuilderInterface: fix getForm() return type.
      Fixed typo in PHPDoc
    fabpot committed Jun 21, 2016
  14. minor #19121 Php cs fixer (fabpot)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Php cs fixer
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    7cc3ca5 fixed CS
    fdef804 tweaked default CS fixer config
    fabpot committed Jun 21, 2016
Commits on Jun 20, 2016
  1. fixed CS

    fabpot committed Jun 20, 2016
  2. tweaked default CS fixer config

    fabpot committed Jun 20, 2016
  3. minor #19116 [Debug] fix resource type test on HHVM (xabbuh)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Debug] fix resource type test on HHVM
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19079
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    2d03ee8 [Debug] fix resource type test on HHVM
    fabpot committed Jun 20, 2016
  4. bug #19114 [HttpKernel] Dont close the reponse stream in debug (nicol…

    …as-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [HttpKernel] Dont close the reponse stream in debug
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19078
    | License       | MIT
    | Doc PR        | -
    
    Because it's `terminate`'s job to clean the state, not the `Response`'s,
    and because the current behavior prevents getting any output on trailing errors on FPM especially.
    
    Commits
    -------
    
    2fbc200 [HttpKernel] Dont close the output stream in debug
    fabpot committed Jun 20, 2016
  5. feature #19090 [Console] Add ConsoleLogger::hasErrored() (nicolas-gre…

    …kas)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Console] Add ConsoleLogger::hasErrored()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    So that it's easy to `exit(1)` whenever any messages have been logged at error levels.
    
    Commits
    -------
    
    cfc578a [Console] Add ConsoleLogger::hasErrored()
    fabpot committed Jun 20, 2016
  6. minor #19115 [FrameworkBundle] fix argument type docblock (xabbuh)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix argument type docblock
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony#18502 (comment)
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    c4e440c [FrameworkBundle] fix argument type docblock
    fabpot committed Jun 20, 2016
  7. minor #19113 [MonologBridge] move HttpKernel component to require sec…

    …tion (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [MonologBridge] move HttpKernel component to require section
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19110
    | License       | MIT
    | Doc PR        |
    
    Nearly every class from the bridge has (directly or indirectly) a dependency on a class from the HttpKernel component. Thus, it for me doesn't make sense to treat it as an optional dependency.
    
    Commits
    -------
    
    138d0cb move HttpKernel component to require section
    fabpot committed Jun 20, 2016
  8. minor #19111 [Console] simplified tests (fabpot)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Console] simplified tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    85e5060 [Console] simplified tests
    fabpot committed Jun 20, 2016
  9. [Console] simplified tests

    fabpot committed Jun 20, 2016
  10. minor #19097 [Console] Test SymfonyStyle::ask() output (chalasr)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Console] Test SymfonyStyle::ask() output
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Now that we can test an interactive command that uses SymfonyStyle (after #18999), we should test their output.
    
    Commits
    -------
    
    e870758 [Console] Test SymfonyStyle::ask() output
    fabpot committed Jun 20, 2016
Commits on Jun 19, 2016
  1. bug #19101 [Session] fix PDO transaction aborted under PostgreSQL (To…

    …bion)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Session] fix PDO transaction aborted under PostgreSQL
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14641
    | License       | MIT
    | Doc PR        |
    
    Fixes the transactional concurrency error handling for PostgreSQL which does not allow to execute further queries in a transaction with an error.
    Because of the loop, look at the diff with whitespace ignored to see the difference: https://github.com/symfony/symfony/pull/19101/files?w=1
    
    Commits
    -------
    
    f8eefa0 [Session] fix PDO transaction aborted under PostgreSQL
    fabpot committed Jun 19, 2016
  2. feature #19079 [Debug] Do not quote numbers in stack trace (c960657)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Debug] Do not quote numbers in stack trace
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    In the debug output from the exception handler, integers and floats are quoted. This adds unnecessary noise to the error page and is just wrong.
    
    Fixing this requires introduces two new type descriptions in the output from getTrace(), so the change is not fully backwards compatible.
    
    Commits
    -------
    
    fb10b33 [Debug] Do not quote numbers in stack trace
    fabpot committed Jun 19, 2016
  3. bug #18501 [HttpFoundation] changed MERGE queries (hjkl)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] changed MERGE queries
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #17284
    | License | MIT
    | Doc PR | N/A
    
    Changed the MERGE queries for Oracle and SQL Server to use question mark parameter markers so they work with emulation disabled or enabled - fixes #17284
    
    Commits
    -------
    
    ebf3a2f Fixed oci and sqlsrv merge queries when emulation is disabled - fixes #17284
    fabpot committed Jun 19, 2016
  4. minor #19094 [Console] Use InputInterface inherited doc as possible (…

    …chalasr)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] Use InputInterface inherited doc as possible
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    In classes implementing `InputInterface`, the methods doc blocks are duplicated from the interface.
    Sometimes descriptions are different from the interface's ones and, sometimes, the class doc is clearer. So I tried to keep always the most adapted one.
    
    Commits
    -------
    
    b604be7 [Console] Use InputInterface inherited doc as possible
    fabpot committed Jun 19, 2016
Commits on Jun 18, 2016
  1. minor #19085 FormBuilderInterface: fix getForm() return type. (taueres)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    FormBuilderInterface: fix getForm() return type.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    FormBuilderInterface->getForm() should depend on abstractions and
    not implementations as a return type.
    
    Commits
    -------
    
    3fa081c FormBuilderInterface: fix getForm() return type.
    Tobion committed Jun 18, 2016