Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIFF BitsPerSample tag: Better default behavior #76

Closed
wolfgang-braun opened this issue Apr 10, 2019 · 1 comment
Closed

TIFF BitsPerSample tag: Better default behavior #76

wolfgang-braun opened this issue Apr 10, 2019 · 1 comment

Comments

@wolfgang-braun
Copy link

wolfgang-braun commented Apr 10, 2019

I've forked golang.org-x-image to implement this change:

d.features[tBitsPerSample] = []uint{1} // BitsPerSample tag is optional in case the value is 1 - if the tag is missing we assume that the tag value is 1

https://github.com/wolfgang-braun/golang.org-x-image/commit/6b0041c359e77950c205cd39cfde0b9a0482d136

Maybe you want to apply it to your repository.

hhrutter added a commit that referenced this issue Apr 13, 2019
@hhrutter
Copy link
Collaborator

Yes, definitely makes sense.
The spec says that 1 is the default for bits per sample.
This is also fixed in the latest commit 14e74ba2

Thanks for taking time on this 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants