Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-114845 Add type to parameterized class usages #4360

Closed
wants to merge 1 commit into from

Conversation

adolfopa
Copy link

@adolfopa adolfopa commented Jun 3, 2020

Hey @hhuijser

These changes should fix weird usages of SearchContainer generics. Let me know what you think about it.

The MB case is much more tricker, so I'll work on that separately.

Thanks!

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@adolfopa
Copy link
Author

adolfopa commented Jun 3, 2020

ci:test:sf

@adolfopa
Copy link
Author

adolfopa commented Jun 3, 2020

ci:test:relevant

@jpince
Copy link

jpince commented Jun 3, 2020

ci:test:sf

@jpince
Copy link

jpince commented Jun 3, 2020

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f380f73537a0445f153e7a055fa36438b312bf69

Sender Branch:

Branch Name: LPS-114845
Branch GIT ID: 6cff9e9615e83ebe8896935ee2c384cd33409574

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 20 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8570edc0382ba6302eaa218697b18c0f49acfa3e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6781f47bc448a9efe3c4df1eac5c1b8c4fc86c4e

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

         [exec] * What went wrong:
         [exec] Execution failed for task ':apps:knowledge-base:knowledge-base-web:compileJSP'.
         [exec] > Compilation failed; see the compiler error output for details.
         [exec] 
         [exec] * Try:
         [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
         [exec] 
         [exec] * Exception is:
         [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:knowledge-base:knowledge-base-web:compileJSP'.
         [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:166)
         [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:163)
         [exec] 	at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:191)
         [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)
         [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:62)
         [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:108)
         [exec] 	at org.gradle.api.internal.tasks.execution.ResolveBeforeExecutionOutputsTaskExecuter.execute(ResolveBeforeExecutionOutputsTaskExecuter.java:67)
         [exec] 	at org.gradle.api.internal.tasks.execution.StartSnapshotTaskInputsBuildOperationTaskExecuter.execute(StartSnapshotTaskInputsBuildOperationTaskExecuter.java:62)
         [exec] 	at org.gradle.api.internal.tasks.execution.ResolveAfterPreviousExecutionStateTaskExecuter.execute(ResolveAfterPreviousExecutionStateTaskExecuter.java:46)
         [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:94)
         [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
         [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:95)
         [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
         [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)

For upstream results, click here.

@hhuijser
Copy link
Owner

hhuijser commented Jun 4, 2020

@adolfopa thanks!

I applied to other cases across the module: #4364

@hhuijser hhuijser closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants