-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernization: introduce pyproject.toml for setuptools configuration #655
Conversation
…tions workflow into tox.ini
… for darwin (regex: darwin, environment name: py-darwin)
I'm not sure that this is backwards-compatible with the |
pyproject.toml
Outdated
authors = [ | ||
{ name = "Hristo Harsev", email = "r+pypi@hharsev.com" }, | ||
] | ||
urls = { Homepage = "https://github.com/hhursev/recipe-scrapers/" } | ||
keywords = ["python", "recipes", "scraper", "harvest", "recipe-scraper", "recipe-scrapers"] | ||
license = { file = "LICENSE" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These four fields have slightly different output in PKG-INFO
, as produced by setuptools
v65.5.0, between the setup.py
approach in the main
branch and the pyproject.toml
approach in this development branch.
Author
andAuthor-email
fields are condensed into a singleAuthor-email
line (Firstname Lastname <username@example.org>
format)- Instead of a single
home-page
URL entry, a list ofProject-URL
entries with associated name, URL pairs is emitted (Homepage, ...
in this case) - Keywords are joined into a comma-separated list
- Instead of a
license-files
entry containing filenames, the license file's content is read and included into thePKG-INFO
file
Those all seem fairly reasonable to me.
The wildcard blob in 5900d6e (used to make sure that settings and plugins are included) doesn't match the top-level module
…ious MANIFEST.in approach [skip ci]
excited about this one! checking out locally and probing right now |
…ure out how to do it through GH UI
This reverts commit 5d9cad4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I basically didn't change a thing (aside from adjusting the publish action). Decided to remove the setup.py file and us building the package with the newer tools.
I hope the [tool.setuptools] table being beta won't bite us (I think it's highly unlikely). We'll be able to react quickly so no real issues imo.
Feel free to merge/bump version whenever
And well spotted @hhursev about the license content in the pypi sidebar.. that's weird/spammy. Looks like it is a known issue (mesonbuild/meson-python#129). |
This builds on top of pull request #650, and is an alternative to #654 -- this time without adding
poetry
as a dependency; instead usingpyproject.toml
to configuresetuptools
.