This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Better HackCodegenConfig::getRootDir() #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should usually be used via composer, so it will end up in PROJECTROOT/vendor/facebook/hack-codegen/ If this is the case, go for that, rather than PROJECTROOT/vendor/facebook/hack-codegen/src/ Tested with `codegen_generated_from_script()` with no args; generated file now contains: ``` * To re-generate this file run vendor/phpunit/phpunit/phpunit ``` Previously it had the *full* path to the script - /Users/fred/.....
ghost
added
the
dienesl
pushed a commit
to dienesl/hack-codegen
that referenced
this pull request
Feb 25, 2023
* re-use stack while recursively calling find_offset_of_leading * use Vec\take instead of array_pop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should usually be used via composer, so it will end up in
PROJECTROOT/vendor/facebook/hack-codegen/
If this is the case, go for that, rather than PROJECTROOT/vendor/facebook/hack-codegen/src/
Tested with
codegen_generated_from_script()with no args; generated filenow contains:
Previously it had the full path to the script - /Users/fred/.....