Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
3.24: add `safe_pass_by_ref` migration #21
This option will be supported in HHVM 3.23+; it requires that callsites specify '&' when passing an argument by ref; for example:
$foo = vec[1,3,2]; sort(&$foo);
With the option off, in 3.23+, the '&' is ignored - but it is an error in master. This can be worked on now if you build HHVM master, or
This requires building support for migrations that query and fix typechecker errors, rather than purely operating on the AST
This ends up highlighting hundreds of issues within hhvm source code itself when used with composer.
As far as I know, there isn't a way to ignore the vendor directory by adding it to your .hhconfig file.
So, how is the above best handled?