From d643a730390a064daedc7a376fa5b0c8a9eeb5e9 Mon Sep 17 00:00:00 2001 From: "Yang, Bo" Date: Tue, 15 Mar 2022 19:34:49 +0000 Subject: [PATCH] Add Condition->trySucceed and Condition->tryFail --- src/async/Condition.php | 44 +++++++++++++++++++++++++++++++---------- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/src/async/Condition.php b/src/async/Condition.php index 64acefab..eb277dc3 100644 --- a/src/async/Condition.php +++ b/src/async/Condition.php @@ -21,34 +21,58 @@ class Condition { * Notify the condition variable of success and set the result. */ final public function succeed(T $result): void { + invariant($this->trySucceed($result), 'Unable to notify Condition twice'); + } + + /** + * Notify the condition variable of failure and set the exception. + */ + final public function fail(\Exception $exception): void { + invariant($this->tryFail($exception), 'Unable to notify Condition twice'); + } + + /** + * Notify the condition variable of success and set the $result. + * + * @return + * true if the condition is set to $result successfully, false if the + * condition was previously set to another result or exception. + */ + final public function trySucceed(T $result): bool { if ($this->condition === null) { $this->condition = async { return $result; }; + return true; } else { - invariant( - $this->condition is ConditionWaitHandle<_>, - 'Unable to notify AsyncCondition twice', - ); + if (!($this->condition is ConditionWaitHandle<_>)) { + return false; + } /* HH_FIXME[4110]: Type error revealed by type-safe instanceof feature. See https://fburl.com/instanceof */ $this->condition->succeed($result); + return true; } } /** - * Notify the condition variable of failure and set the exception. + * Notify the condition variable of failure and set the $exception. + * + * @return + * true if the condition is set to $exception successfully, false if the + * condition was previously set to another result or exception. */ - final public function fail(\Exception $exception): void { + final public function tryFail(\Exception $exception): bool { if ($this->condition === null) { $this->condition = async { throw $exception; }; + return true; } else { - invariant( - $this->condition is ConditionWaitHandle<_>, - 'Unable to notify AsyncCondition twice', - ); + if (!($this->condition is ConditionWaitHandle<_>)) { + return false; + } $this->condition->fail($exception); + return true; } }