Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Do we want the HTML xhp classes to be final in v4? #265

Closed
lexidor opened this issue Jul 8, 2020 · 0 comments
Closed

Do we want the HTML xhp classes to be final in v4? #265

lexidor opened this issue Jul 8, 2020 · 0 comments
Labels

Comments

@lexidor
Copy link
Contributor

lexidor commented Jul 8, 2020

Quote Fred Emmott: hhvm/hhast#284 (comment)

These should be changed (nice catch ;) ) - I wouldn't expect extending any of the HTML classes to end well :/ XHP really needs composition over inheritance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants