Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Invalid escaping in renderBaseAttrs #31

Merged
merged 1 commit into from Feb 15, 2012

Conversation

Projects
None yet
2 participants

vrana commented Feb 15, 2012

Summary:
Second parameter of htmlspecialchars() is flags (int), not bool.
Value true is understood as 1 which means: quote single quotes, not double quotes

Test Plan:
New test

Invalid escaping in renderBaseAttrs()
Summary:
Second parameter of htmlspecialchars() is flags (int), not bool.
Value true is understood as 1 which means: quote single quotes, not double quotes

Test Plan:
New test

scottmac added a commit that referenced this pull request Feb 15, 2012

Merge pull request #31 from vrana/master
Invalid escaping in renderBaseAttrs

@scottmac scottmac merged commit 17f05e1 into hhvm:master Feb 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment