Skip to content

Commit

Permalink
OGM-1510 Remove some references to protostream internals
Browse files Browse the repository at this point in the history
  • Loading branch information
anistor committed Jul 2, 2018
1 parent b20aa93 commit 53d943a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
Expand Up @@ -9,7 +9,6 @@
import java.io.IOException;
import java.lang.invoke.MethodHandles;
import java.net.URL;
import java.util.Map;

import org.hibernate.HibernateException;
import org.hibernate.ogm.datastore.infinispanremote.impl.schema.SequenceTableDefinition;
Expand All @@ -21,9 +20,10 @@

import org.infinispan.protostream.DescriptorParserException;
import org.infinispan.protostream.FileDescriptorSource;
import org.infinispan.protostream.ProtobufUtil;
import org.infinispan.protostream.SerializationContext;
import org.infinispan.protostream.config.Configuration;
import org.infinispan.protostream.descriptors.FileDescriptor;
import org.infinispan.protostream.impl.parser.SquareProtoParser;

/**
* Validate a user defined schema using ProtoStream library
Expand Down Expand Up @@ -73,8 +73,8 @@ private void validate() {
try {
fileDescriptor = parseSchema();
}
catch (DescriptorParserException descriptorParserException) {
throw LOG.providedSchemaHasAnIllegalFormat( descriptorParserException.getMessage(), protoSchema );
catch (DescriptorParserException | IOException e) {
throw LOG.providedSchemaHasAnIllegalFormat( e.getMessage(), protoSchema );
}

if ( !owner.packageName.equals( fileDescriptor.getPackage() ) ) {
Expand All @@ -92,12 +92,11 @@ private void validate() {
}
}

private FileDescriptor parseSchema() {
private FileDescriptor parseSchema() throws DescriptorParserException, IOException {
FileDescriptorSource fileDescriptorSource = FileDescriptorSource.fromString( schemaName, protoSchema );
Configuration config = Configuration.builder().build();

SquareProtoParser protoParser = new SquareProtoParser( config );
Map<String, FileDescriptor> fileDescriptorMap = protoParser.parse( fileDescriptorSource );
return fileDescriptorMap.get( schemaName );
SerializationContext serCtx = ProtobufUtil.newSerializationContext( config );
serCtx.registerProtoFiles( fileDescriptorSource );
return serCtx.getFileDescriptors().get( schemaName );
}
}
Expand Up @@ -15,9 +15,9 @@
import org.hibernate.ogm.datastore.infinispanremote.logging.impl.LoggerFactory;
import java.lang.invoke.MethodHandles;
import org.infinispan.protostream.DescriptorParserException;
import org.infinispan.protostream.ProtobufUtil;
import org.infinispan.protostream.SerializationContext;
import org.infinispan.protostream.config.Configuration;
import org.infinispan.protostream.impl.SerializationContextImpl;

public class ProtostreamSerializerSetup {

Expand All @@ -30,7 +30,7 @@ private ProtostreamSerializerSetup() {
public static SerializationContext buildSerializationContext(
SchemaDefinitions sd, MainOgmCoDec delegate, OgmProtoStreamMarshaller marshaller) throws DescriptorParserException, IOException {
Configuration cfg = Configuration.builder().setLogOutOfSequenceReads( true ).build();
SerializationContextImpl serContext = new SerializationContextImpl( cfg );
SerializationContext serContext = ProtobufUtil.newSerializationContext( cfg );
IdMessageMarshaller idM = new IdMessageMarshaller( delegate );
PayloadMessageMarshaller valueM = new PayloadMessageMarshaller( delegate );
try {
Expand All @@ -52,7 +52,7 @@ public static SerializationContext buildSerializationContext(
public static SerializationContext buildSerializationContextForSequences(
SchemaDefinitions sd, SequenceTableDefinition std) {
Configuration cfg = Configuration.builder().setLogOutOfSequenceReads( true ).build();
SerializationContextImpl serContext = new SerializationContextImpl( cfg );
SerializationContext serContext = ProtobufUtil.newSerializationContext( cfg );
try {
serContext.registerProtoFiles( sd.asFileDescriptorSource() );
}
Expand Down

0 comments on commit 53d943a

Please sign in to comment.