New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGM-1287 Create a property to look up native nosql connection via JNDI #1045
Conversation
128400a
to
bbcbc71
Compare
[NOTE] | ||
==== | ||
If you have provisioned your WildFly with Hibernate Ogm featurepack(s), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Ogm/OGM/
---- | ||
|
||
At this point you can use Hibernate property `hibernate.connection.resource` in your _persistence.xml_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/can use Hibernate property/can use the Hibernate property/
bbcbc71
to
a0af99c
Compare
Thank you @Sanne for the typo fixes. I applied them and rebased the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, would it be possible to add some tests in the integrationtest
module?
} | ||
|
||
// clear resources | ||
this.jndiService = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical but I find it counter intuitive that the lookup method also does the clear, can we move it at the end of the start method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can
} | ||
|
||
// clear resources | ||
this.jndiService = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical but I find it counter intuitive that the lookup method also does the clear, can we move it at the end of the start method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can
a0af99c
to
9f90caf
Compare
Are you working on this? |
@DavideD good idea. I'm going to start to work on it. |
344b980
to
920f0b6
Compare
Thank you @DavideD |
https://hibernate.atlassian.net/browse/OGM-1287